Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More strict error handling may be required in Monotonic #3

Open
hnes opened this issue Sep 16, 2017 · 0 comments
Open

More strict error handling may be required in Monotonic #3

hnes opened this issue Sep 16, 2017 · 0 comments

Comments

@hnes
Copy link

hnes commented Sep 16, 2017

Hi, I am not good at golang's asm, but the implementation logic probably seems not so strict in the monotime/mono_linux_amd64.s:

  1. As the __vdso_clock_gettime_sym may not support CLOCK_MONOTONIC_RAW ($ man clock_gettime: since Linux 2.6.28; Linux-specific), so we should also check the ret status (EINVAL|EFAULT|EPERM).

  2. When vdso_is_sad is been executed, the monotime's ret is also invalid. But it seems that there does not have any checking codes in the go function Monotonic.

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant