Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage stdatamodels issues and fix small bugs #9166

Closed
stscijgbot-jp opened this issue Feb 10, 2025 · 1 comment
Closed

Triage stdatamodels issues and fix small bugs #9166

stscijgbot-jp opened this issue Feb 10, 2025 · 1 comment

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-3876 was created on JIRA by Ned Molter:

There is a backlog of GitHub issues that lack associated Jira tickets and therefore prioritization.  The Jira bot does not xref stdatamodels issues to Jira, only jwst issues.  Therefore, tickets must be written for stdatamodels issues by hand.

 

Some of the issues are small and do not merit their own tickets, but fixes need to be pushed anyway.  This ticket also covers that work.

@stscijgbot-jp
Copy link
Collaborator Author

stscijgbot-jp commented Feb 12, 2025

Comment by Ned Molter on JIRA:

Triage is now complete.  Labels have been added to all open stdatamodels issues (no label means it's workable, with no other comments), see here

https://github.com/spacetelescope/stdatamodels/issues

8 issues have been closed since yesterday, and one moved into jwst.

Several issues have been grouped into medium-sized or large tasks and turned into Jira tickets; see the list of tickets this is "triggering" above.

I'm keeping this ticket open to cover work on four small and (hopefully) easily-fixed stdatamodels issues:

spacetelescope/stdatamodels#307 reports a bug where the schema ndim and max_ndim are not respected when datamodels are initialized from shapes, or from other datamodels. Half fixed by spacetelescope/stdatamodels#395 MERGED, which handles initializing from a shape. Other half fixed by spacetelescope/stdatamodels#403 , which forces array validation when initializing from other datamodels MERGED

spacetelescope/stdatamodels#186 reports a bug where the NirspecQuadFlatModel could not be initialized by a NirspecFlatModel, despite clear effort by the original author to support that. Fixed by spacetelescope/stdatamodels#401 MERGED](spacetelescope/stdatamodels#186)

spacetelescope/stdatamodels#16 Asks for removal of the deprecated get_fileext() method. Removed by spacetelescope/stdatamodels#400 MERGED](spacetelescope/stdatamodels#400)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant