You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All of the models defined in wcs_ref_models need identical on_save and to_fits as well as much of the same functionality in their respective validate() methods. There is already a base class named _SimpleModel that contains these methods. However, there are 11 different models that do not inherit from _SimpleModel, so lots of repeated code remains.
It would be useful to refactor this (using, e.g., a mixin pattern) so that all the models can benefit from the implementations in the base class or classes.
The text was updated successfully, but these errors were encountered:
All of the models defined in
wcs_ref_models
need identicalon_save
andto_fits
as well as much of the same functionality in their respectivevalidate()
methods. There is already a base class named_SimpleModel
that contains these methods. However, there are 11 different models that do not inherit from_SimpleModel
, so lots of repeated code remains.It would be useful to refactor this (using, e.g., a mixin pattern) so that all the models can benefit from the implementations in the base class or classes.
The text was updated successfully, but these errors were encountered: