Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slicedimage uses sptx-format validator to validate input images #28

Open
ambrosejcarr opened this issue Aug 14, 2018 · 3 comments
Open

Comments

@ambrosejcarr
Copy link
Member

slicedimage should outsource validation to sptx-formats, allowing us to keep any refactoring of spec-related changes to one place.

ACs:

  • slicedimage imports sptx-format
  • all validation occurs in imported tool.
@joshmoore
Copy link
Member

My understanding is that this is no longer accurate?

@ambrosejcarr
Copy link
Member Author

I believe we are deferring a decision on this. The most important things are currently:

  • validation occurs somewhere
  • dependencies between repositories are clear
  • sptx-format, starfish, and slicedimage have consistent code states (suggested implementation: through pinned versioning)

@joshmoore
Copy link
Member

s/no longer accurate/postponed/ in the sense that a PR for making this repo depend on sptx-format is not immediatelysloted. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants