Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Parameters in Tile.py, TileSet.py #67

Open
ambrosejcarr opened this issue Sep 24, 2018 · 2 comments
Open

Document Parameters in Tile.py, TileSet.py #67

ambrosejcarr opened this issue Sep 24, 2018 · 2 comments

Comments

@ambrosejcarr
Copy link
Member

I was trying to use these to crop and found it difficult to understand what was going on without reading all the source code.

Additional point of confusion: it would be awesome if TileSet (via delegation to Tile, perhaps) could have a read and write methods, instead of going through an external Reader class.

Ideally I'd like to be able to read the TileSet, manipulate it, and then dump it to disk. I struggled to accomplish this without writing janky new code.

@ttung
Copy link
Collaborator

ttung commented Sep 24, 2018

This should be like 3-5 lines of code, no?

The generate_partition_document + write to file could be simplified probably.

@ambrosejcarr
Copy link
Member Author

This should be like 3-5 lines of code, no?

Yes to cropping, no to documentation, which probably should be a bit more verbose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants