Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xarray versions 2023.9+ introduce new errors in testing #2031

Open
shachafl opened this issue Nov 13, 2024 · 0 comments
Open

xarray versions 2023.9+ introduce new errors in testing #2031

shachafl opened this issue Nov 13, 2024 · 0 comments
Labels
bug An issue with an existing feature dependencies Pull requests that update a dependency file

Comments

@shachafl
Copy link
Collaborator

Description

Currently xarray is kept at version 2023.8 as newer versions introduce errors in testing.

Steps/Code to Reproduce

source .venv3.9/bin/activate
make install-dev
pip update -U xarray
make fast-test

Expected Results

No error is thrown when running make fast-test.
Output: "...370 passed, 3 skipped, 118 warnings..."

Actual Results

For xarray 2023.9-2024.6 we get the following errors:
FAILED starfish/core/image/Filter/test/test_api_contract.py::test_all_methods_adhere_to_contract[DeconvolvePSF] - ValueError: new dimensions ('y', 'x') must be a superset of existing dimensions ('dim_0', 'dim_1')
FAILED starfish/test/full_pipelines/api/test_merfish.py::test_merfish_pipeline_cropped_data - ValueError: new dimensions ('y', 'x') must be a superset of existing dimensions ('dim_0', 'dim_1')

for xarray 2024.7+ we get a new error:
FAILED starfish/core/image/Filter/test/test_zero_by_channel_magnitude.py::test_zero_by_channel_magnitude_produces_accurate_results - ValueError: ('c', 'z', 'y', 'x') must be a permuted list of ('r', 'c', 'z', 'y', 'x'), unless ... is included
FAILED starfish/core/image/Filter/test/test_api_contract.py::test_all_methods_adhere_to_contract[ZeroByChannelMagnitude] - ValueError: ('c', 'z', 'y', 'x') must be a permuted list of ('r', 'c', 'z', 'y', 'x'), unless ... is included
FAILED starfish/test/full_pipelines/api/test_dartfish.py::test_dartfish_pipeline_cropped_data - ValueError: ('c', 'z', 'y', 'x') must be a permuted list of ('r', 'c', 'z', 'y', 'x'), unless ... is included

Versions

Linux-5.15.153.1-microsoft-standard-WSL2-x86_64-with-glibc2.35
Python 3.9.18 (main, May 17 2024, 10:28:50)
[GCC 11.4.0]
NumPy 1.26.4
SciPy 1.13.1
scikit-image 0.21.0
pandas 2.2.3
sklearn 1.5.2
xarray 2023.8.0 (old)
xarray 2024.7.0
sympy 1.13.3
starfish 0.2.2+47.ga4fb2260

@shachafl shachafl added bug An issue with an existing feature dependencies Pull requests that update a dependency file labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with an existing feature dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant