Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the 'exec' option does not support paths with special characters #28

Open
jnolles opened this issue Jun 15, 2016 · 0 comments
Open

the 'exec' option does not support paths with special characters #28

jnolles opened this issue Jun 15, 2016 · 0 comments

Comments

@jnolles
Copy link

jnolles commented Jun 15, 2016

Example configuration which fails on Linux:

options: {
    failOnError: true
  },
  updateAllPackages: {
    exec: '/workspace/Some project name (branch 2.10)/updateAllPackages'
  }

It fails because the 'exec' value is not escaped with quotes here (while the Windows variant is):

    if (this.data.exec) {
      // logic is from node's cp.exec method, adapted to benefit from
      // streaming io
      if (process.platform === 'win32') {
        cmd = 'cmd.exe';
        args = ['/s', '/c', '"' + this.data.exec + '"'];
        spawnOpts.windowsVerbatimArguments = true;
      } else {
        cmd = '/bin/sh';
        args = ['-c', this.data.exec];
      }

Please change args = ['-c', this.data.exec]; to args = ['-c', '"' + this.data.exec + '"']; on row 112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant