Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a client doesn't send a connection message, it may appear to be connected #14

Open
mdwaud opened this issue Feb 8, 2023 · 0 comments

Comments

@mdwaud
Copy link
Collaborator

mdwaud commented Feb 8, 2023

Expected Behavior
A client that has not completed the connection request / response handshake does not show as connected in Sink.Server.connected_clients

Observed Behavior
Really old clients that needed to be updated and weren't sending connection requests showed up as connected.

This is because the registry doesn't differentiate between clients / processes with open TCP connections and those which have completed the connection process.

LostKobrakai added a commit that referenced this issue Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant