Error when trying to set maximumCrawlCount

[goodjobs-ta]

Hi,
when I try to set the maximumCrawlCount value and create a sitemap afterwards I run into the following error:

Call to undefined method Spatie\Crawler\Crawler::setMaximumCrawlCount()
at vendor/spatie/laravel-sitemap/src/SitemapGenerator.php:117

The function 'setMaximumCrawlCount' seems to be missing on the 'Spatie\Crawler\Crawler'.
I think It must be used 'setTotalCrawlLimit' instead.

[jadersbr]

Did you resolve this error? Same error here, but acordant to documentation, we needs to use use Spatie\Sitemap\SitemapGenerator; and inside this class has setMaximumCrawlCount. I got this error message Call to undefined method Spatie\Crawler\Crawler::setMaximumCrawlCount().

[BoGnY]

Yeah it's a bug..
I've resolved extending SitemapGenerator class and overwriting getSitemap() function with my personal App\Support\SitemapGenerator and changing this:

        if (! is_null($this->maximumCrawlCount)) {
            $this->crawler->setMaximumCrawlCount($this->maximumCrawlCount);
        }

With this:

        if (! is_null($this->maximumCrawlCount)) {
            $this->crawler->setTotalCrawlLimit($this->maximumCrawlCount);
        }

Then instead using Spatie\Sitemap\SitemapGenerator just use App\Support\SitemapGenerator.

Cheers 👍🏻

[goodjobs-ta]

Ok, thanks so far. So if this a bug, where to open an issue for it?!

[BoGnY]

I create PR on #490 👍🏻

[goodjobs-ta]

@BoGnY Thanks!

[BoGnY]

PR merged, fixed in version 6.2.5 👍🏻

[goodjobs-ta]

Great news!