Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README update #230

Closed
wants to merge 5 commits into from
Closed

README update #230

wants to merge 5 commits into from

Conversation

ncla
Copy link
Collaborator

@ncla ncla commented May 20, 2023

There has been lots of updates but README has been left behind a bit.

Few things I want to do:

  • Organize all tag parameters into one place / section
  • Explain how to extend DimensionCalculator
  • Explain how generating/regenerating responsive images only makes sense if you do not pass any tag params or change ratio
  • Start out the README with how to quickly get up to speed, how to.. just use this addon fast as possible
  • Remove the YAML configuration because I think simply creating the blueprint in control panel is way much easier, lets not bore the reader with such details, plus the configuration looked mostly default
  • Update the fieldtype image to a video; consume less space vertically in terms of the media dimensions

@spatie-bot
Copy link

Dear contributor,

because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it.

@spatie-bot spatie-bot closed this Sep 22, 2023
@riasvdv riasvdv reopened this Sep 22, 2023
@ncla
Copy link
Collaborator Author

ncla commented Sep 22, 2023

Quicker than me, wow. :D

I've been quite busy in my life, so these two PRs are kinda hanging. :/

@spatie-bot
Copy link

Dear contributor,

because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it.

@spatie-bot spatie-bot closed this Jan 23, 2024
@ncla ncla reopened this May 4, 2024
@spatie-bot
Copy link

Dear contributor,

because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it.

@spatie-bot spatie-bot closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants