Workflow for deploying to github pages #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbennun
reviewed
Dec 15, 2023
| - name: Upload artifact | ||
| uses: actions/upload-pages-artifact@v2 | ||
| with: | ||
| path: '.' |
There was a problem hiding this comment.
shouldn't this be dist then?
There was a problem hiding this comment.
It needs more than dist, for example the HTML file
tbennun
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way of deploying the webclient is through the dace repository. There are a few problems with that:
distis not part of the git repository anymore, for good reasons, so it's a hack to get it uploaded on the deployment.The idea with this PR is to automatically keep the deployment active when changes are made here, and then the main github pages from the dace repository simply redirects to the webclient where applicable, rather than hosting it itself.