-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.12 #1384
Comments
@BenWeber42 @phschaad could we add this to the next release, which should be a major release? |
Sure, we'll make sure to include it, thanks |
I'm answering my own comments in the top message:
|
There is a new |
Instead of disallowing them we might want to skip those as they’re noops. |
After doing some testing, I decided to disallow the type statement ( Consider the following DaCe program using the new type statement: @dace.program
def type_statement():
type Scalar[T] = T
A: Scalar[dace.float32] = 0
return A Without any changes to the frontend, the above program will fail because @dace.program
def type_statement():
A: dace.float32 = 0
return A Therefore, I believe that considering the type statement a no-op will only result in "minor" errors for users that use the type statement, which will be difficult to debug. I think the best course of action is to explicitly disallow the statement until we are ready to properly support it. |
I'm also in favor of disallowing for now. Searching ast module for 3.12, there are more changes. New classes:
And some classes got a |
On second thought, I agree with you both. |
I will make sure to handle the release with @BenWeber42 before the next dace meeting. |
To add support for Python 3.12:
The text was updated successfully, but these errors were encountered: