Issue a warning when to_sdfg() ignores the auto_optimize flag (Issue #1380).
#1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it was discussed the ignoring of the `auto_optimize` flag in `to_sdfg()` is intentional. To make it clear to the user the function now issues a warning in this case.
tbennun
requested changes
Oct 16, 2023
Co-authored-by: Tal Ben-Nun <[email protected]>
|
Please change the PR title to be more descriptive. It will become the commit message after merging the PR. Thanks for the contribution 👍 |
philip-paul-mueller
changed the title
to_sdfg() ignores the auto_optimize flag (Issue #1380).
|
@BenWeber42 Renamed the issue. |
|
Test failure seems to be spurious (see #1421). I initiated a re-run. Hopefully, it'll pass (I enabled debug-log, this might help otherwise). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was discussed the ignoring of the
auto_optimizeflag into_sdfg()is intentional. To make it clear to the user the function now issues a warning in this case.