Control Flow Raising #1657
Merged
Control Flow Raising #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phschaad
force-pushed
the
cf_block_data_deps
branch
from
3a6104f
to
02d53fc
Compare
tbennun
requested changes
Oct 10, 2024
| itvar, rng, _ = xform.loop_information() | ||
| assert itvar == 'i' | ||
| assert rng == (0, dace.symbol('N') - 1, 1) | ||
| assert sdfg.apply_transformations(xform) == 0 |
There was a problem hiding this comment.
this is very weird because they are loops. We should discuss.
I wonder why this is not detected as a loop because the exiting state (latch->increment1) should have the branch in this case and the latch itself is increment2. This should count as a separate_latch=True case.
There was a problem hiding this comment.
I think the easiest solution is just to run state fusion - then that state vanishes anyway and the loop is detected normally.
There was a problem hiding this comment.
Still strange, maybe ok. We will see as it directly affects my frontend (my states cannot be fused afaik). Is it because of the graph patterns?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly provides control flow raising passes for the new intrinsic control flow constructs (Branches and loops) in SDFGs. In addition to raising, the state and control flow reachability passes have been adjusted to faithfully work with the intrinsic control flow constructs.
Along with the raising and reachability passes, a few important bugfixes and a general cleanup is included in the PR, but no other functionality is changed.