Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Echidna build failure from attempt to display ReSpec error #4825

Open
gkellogg opened this issue Nov 4, 2024 · 4 comments · May be fixed by #4834
Open

Echidna build failure from attempt to display ReSpec error #4825

gkellogg opened this issue Nov 4, 2024 · 4 comments · May be fixed by #4834
Labels
bug

Comments

@gkellogg
Copy link
Contributor

gkellogg commented Nov 4, 2024

Description of problem

URL to affected spec or repo:

https://github.com/w3c/rdf-semantics

What happened (e.g., it crashed)?:

Automatic Echidna build fails trying to display an error.

Expected behavior (e.g., it shouldn't crash):

It should present whatever error triggered the failure.

Optional, steps to reproduce:

  1. Download the better-html branch from https://github.com/w3c/rdf-semantics.
  2. python -m http.server
  3. respec -s "http://localhost:8000/spec/" -o /dev/null --verbose -t 20 -e
[INFO] [Timeout: 20000ms] Processing resource: http://localhost:8000/rdf-semantics/spec/ ...
[INFO] [Timeout: 20000ms] Launching browser
[INFO] [Timeout: 19572ms] Navigating to http://localhost:8000/rdf-semantics/spec/
[INFO] [Timeout: 19197ms] Navigation complete.
[INFO] [Timeout: 19173ms] Using ReSpec v35.1.2
[INFO] [Timeout: 19173ms] Processing ReSpec document...
file:///opt/homebrew/lib/node_modules/respec/tools/respec2html.js:62
    const message = colors.red(this._formatMarkdown(rsError.message));
                                                            ^

TypeError: Cannot read properties of null (reading 'message')
    at Logger.error (file:///opt/homebrew/lib/node_modules/respec/tools/respec2html.js:62:61)
    at onError (file:///opt/homebrew/lib/node_modules/respec/tools/respecDocWriter.js:55:13)
    at file:///opt/homebrew/lib/node_modules/respec/tools/respecDocWriter.js:337:16

Node.js v22.8.0

I'm not sure how rsError could be null here, but it relates to generating the term index. If you remove the <section id="index"></section> it builds without a problem.
@gkellogg gkellogg added the bug label Nov 4, 2024
@gkellogg gkellogg mentioned this issue Nov 4, 2024
Open
@gkellogg
Copy link
Contributor Author

Ping, can this issue get some attention?

@sidvishnoi
Copy link
Member

sidvishnoi commented Nov 22, 2024 •
edited
Loading

There is something in rdf-semantics repo, which breaks dfn-index. The dfn with id "dfn-rdf-vocabulary" doesn't exist by the time we're processing dfn-index.

Image

I'm investigating why that dfn doesn't exist, why it was processed if it doesn't exist, and why rsError is null in that case.

@sidvishnoi sidvishnoi mentioned this issue Nov 22, 2024
Draft
@sidvishnoi
Copy link
Member

sidvishnoi commented Nov 22, 2024 •
edited
Loading

Something due to:
https://github.com/w3c/rdf-semantics/blob/84888afb49d9d669d1d248005076d3c183709d27/spec/index.html#L1120
and https://github.com/w3c/rdf-semantics/blob/84888afb49d9d669d1d248005076d3c183709d27/spec/index.html#L954

@sidvishnoi sidvishnoi linked a pull request Nov 22, 2024 that will close this issue
Open
@sidvishnoi
Copy link
Member

Figured out. Sent PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core/dfn-index): handle section number references with .notoc speced/respec
2 participants
@gkellogg @sidvishnoi