Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch edit improvements #6170

Open
sharadsw opened this issue Jan 29, 2025 · 1 comment
Open

Batch edit improvements #6170

sharadsw opened this issue Jan 29, 2025 · 1 comment
Labels
1 - Enhancement Improvements or extensions to existing behavior Batch Edit

Comments

@sharadsw
Copy link
Contributor

From #5417 (review)

  1. Currently, there is no way to select specific rows and batch edit just them. This might be a requirement, maybe not. There is a work around to do so. The current implementation supports batch edit out of a record set. So, the user can:
  • Make a query.
  • Select the records, make record set out of it.
  • Query out of the record set, and batch edit on those results.
  1. Data sorting. Currently, if you have one table (so no relationships), sorting should always (of multiple columns) be respected (UX guys: test this). If you have relationships, and you also sort on some of the relationship's columns, it's essentially arbitrary (no guarantees regarding what user sees). From the code perspective, it is not arbitrary (see if you can figure those places out). I know that we don't support relationships, but this point actually applies regardless, since the same procedure is applied, just that we ignore relationships in upload plan. This might UX issue, a way to work around will be to sort in the workbench instead (in the spreadsheet).
  1. Potential performance issues, as mentioned in a below comment in stored_queries/views.py. IIRC, I once tried batch editing andy's entire voucher collection (45k CO records with determination and cataloger) and it took 1.2 minutes to construct the dataset (I think that's too slow - I deferred profiling it for later, maybe need to that).
@sharadsw sharadsw added 1 - Enhancement Improvements or extensions to existing behavior Batch Edit labels Jan 29, 2025
@sharadsw
Copy link
Contributor Author

Improvements related to code:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Enhancement Improvements or extensions to existing behavior Batch Edit
Projects
None yet
Development

No branches or pull requests

1 participant