Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Data for Teams #120

Open
Floha258 opened this issue Jan 9, 2022 · 4 comments
Open

Custom Data for Teams #120

Floha258 opened this issue Jan 9, 2022 · 4 comments

Comments

@Floha258
Copy link

Floha258 commented Jan 9, 2022

The name basically says it already, currently customData is only available for players of a team and a run itself, however not for a team in itself.
Depending on how many players there are per team it might not be the best decision to give every player the custom Data that a team is only needed once per team.

@zoton2
Copy link
Contributor

zoton2 commented Jan 9, 2022

I can add this very easily, just not sure if it will be able to be imported from anywhere. If you need that, are there any ideas on how you'd do that?

@Floha258
Copy link
Author

I would probably go about it similar as for single players, just make a customData field, which is an array of potential customData.

not sure if it will be able to be imported from anywhere

What would be the issue with that, if you would code it similar to the runner customData?

@zoton2
Copy link
Contributor

zoton2 commented Jan 10, 2022

Well right now the player custom data doesn't get imported automatically from any schedule or external source so, uh, I guess there's no "issue" because it doesn't have it yet. Just adding the structure is fine.

@Floha258
Copy link
Author

My usecase (albeit a bit special) is a direct import in speedcontrol format already, so I have all the data at hand already.
As said my usecase is rather special, but since player customData exists already, I feel like team customData should exist as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants