Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message twitchStartCommercial does not return promise/callback #132

Open
nicnacnic opened this issue Jun 2, 2022 · 2 comments
Open

Message twitchStartCommercial does not return promise/callback #132

nicnacnic opened this issue Jun 2, 2022 · 2 comments
Labels

Comments

@nicnacnic
Copy link
Contributor

In the docs, twitchStartCommercial should be able to return a callback/promise, but instead it doesn't do that. It returns undefined instead and throws an error if you try to use a .then() .catch() block or the callback function.

@nicnacnic nicnacnic changed the title Message twitchStartCommercial does not send promise/callback Message twitchStartCommercial does not return promise/callback Jun 2, 2022
@zoton2
Copy link
Contributor

zoton2 commented Jun 2, 2022

I think I fixed that in this commit? It's just not been in any stable version yet as I hadn't released one. Should do that soon. Not sure if this fixes all of the problem though.

@zoton2
Copy link
Contributor

zoton2 commented Jan 22, 2023

If that commit did fix this, then I've just released it as part of v2.5.0. Will close this if I hear nothing else.

@zoton2 zoton2 added the bug label Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants