Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Twitch game set when game name has trailing space #136

Open
strotlog opened this issue Oct 20, 2022 · 0 comments
Open

Wrong Twitch game set when game name has trailing space #136

strotlog opened this issue Oct 20, 2022 · 0 comments

Comments

@strotlog
Copy link

Steps:

  1. Use the game name "Midnight Manor " <- note the trailing space
  2. Set Twitch status using the game name

Bug: The game is inadvertently set to 'Delaware St. John: Volume 1: The Curse of Midnight Manor' (id=7941)
Expected: The game is set to 'Midnight Manor' (id=906445956), or an error is thrown

Looks like src/extension/srcom-api.ts has an opportunity where it could trim the string. Since it does not currently trim, the exact API fails and searchForTwitchGame goes on to call Twitch's "unsupported API", always selecting the first match from that. This behavior results in weird game names appearing for unclear reasons, as spaces often cannot be seen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant