Exit with code 0 when invalid subcommand is passed

[ldufresnegs]

Hey, I might be missing something completely, but there seems to be a undesirable behavior when an invalid sub-command is passed. Indeed, the help is shown, but the exit code is 0.

The following code early exit when there is the error is flag.ErrHelp which I assume is meant for when the -h is passed, but also happen when an invalid sub-command is passed.

cobra/command.go

Lines 1094 to 1097 in bd4d165

	if errors.Is(err, flag.ErrHelp) {
	cmd.HelpFunc()(cmd, args)
	return cmd, nil
	}

Indeed, in execute(), there is the following:

cobra/command.go

Lines 918 to 920 in bd4d165

	if !c.Runnable() {
	return flag.ErrHelp
	}

I'm I missing something? It seems that the desirable behavior would be to return an error when an invalid sub-command is passed.

The only workaround that may work is to call ExecuteC and check that the returned sub-command is not the root command.
Edit: Nevermind, can't distinguish with an --help flag.

[marckhouzam]

Duplicate of #1156