Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"./flag_test.go:1242:3: fmt.Println arg list ends with redundant newline" with go >= 1.18 #368

Open
pterjan opened this issue Dec 21, 2022 · 0 comments · May be fixed by #369
Open

"./flag_test.go:1242:3: fmt.Println arg list ends with redundant newline" with go >= 1.18 #368

pterjan opened this issue Dec 21, 2022 · 0 comments · May be fixed by #369

Comments

@pterjan
Copy link

pterjan commented Dec 21, 2022

I get a test failure with go 1.19.4 (amd64):

# github.com/spf13/pflag
./flag_test.go:1242:3: fmt.Println arg list ends with redundant newline
FAIL	github.com/spf13/pflag [build failed]

The behaviour changed in 1.18 golang/go#57059

Changing the line to fmt.Print("\n" + defaultOutput + "\n") fixes it.
pterjan added a commit to pterjan/pflag that referenced this issue Dec 21, 2022
@pterjan
Fix TestPrintDefaults with go >= 1.18
ebb7e38 
It no longer accepts Println with a constant ending with a newline:

 Fixes spf13#368

./flag_test.go:1242:3: fmt.Println arg list ends with redundant newline
FAIL    github.com/spf13/pflag [build failed]

Also changing the previous line ven if it si not constant for
consistency.
@pterjan pterjan linked a pull request Dec 21, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TestPrintDefaults with go >= 1.18 pterjan/pflag
1 participant
@pterjan