Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Optimize installation and replacement of kdoctor #2648

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

ty-dc
Copy link
Collaborator

@ty-dc ty-dc commented Nov 23, 2023

Thanks for contributing!

What type of PR is this?

  • release/none

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2191 #2446

Special notes for your reviewer:

@ty-dc ty-dc added pr/not-ready not ready for merging release/none no release note labels Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #2648 (79887e7) into main (1c549c0) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2648      +/-   ##
==========================================
- Coverage   81.06%   81.00%   -0.06%     
==========================================
  Files          49       49              
  Lines        5339     5339              
==========================================
- Hits         4328     4325       -3     
- Misses        854      856       +2     
- Partials      157      158       +1     
Flag Coverage Δ
unittests 81.00% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@@ -41,7 +41,7 @@ INSTALL_MACVLAN ?= true

INSTALL_MULTUS ?= true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个变量 是否已经不需要了 ?

INSTALL_NETTOOLS ?= false

INSTALL_SPIDERDOCTOR ?= true
INSTALL_KDOCTOR ?= true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对本本地开发人员,这个默认也是不需要的

Makefile Outdated
@@ -308,7 +308,7 @@ e2e_init:

.PHONY: e2e_init_underlay
e2e_init_underlay:
$(QUIET) make e2e_init -e INSTALL_OVERLAY_CNI=false -e E2E_SPIDERPOOL_ENABLE_SUBNET=true
$(QUIET) make e2e_init -e INSTALL_OVERLAY_CNI=false -e E2E_SPIDERPOOL_ENABLE_SUBNET=true -e INSTALL_KRUISE=true
Copy link
Collaborator

@weizhoublue weizhoublue Nov 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

希望 e2e_init_underlay 是本地开发,精简的
因此,INSTALL_KRUISE=true 等变量 应该是 github action 代码中打开 ,而不是这

@ty-dc ty-dc force-pushed the e2e/optimization branch 2 times, most recently from 77bcca8 to aad8466 Compare November 24, 2023 08:46
@ty-dc ty-dc closed this Nov 24, 2023
@ty-dc ty-dc reopened this Nov 24, 2023
@ty-dc
Copy link
Collaborator Author

ty-dc commented Nov 24, 2023

pr-ci 识别不到我修改的这几个变量呢?能怎么修下... @weizhoublue

                -e INSTALL_KUBEVIRT=true \
                -e INSTALL_KRUISE=true \
                -e INSTALL_KDOCTOR=true

手动通过 action 触发,正常。

image

@weizhoublue
Copy link
Collaborator

先往 main 合入 action 的修改 即可 验证本 pr

@ty-dc ty-dc force-pushed the e2e/optimization branch 5 times, most recently from 9ff5af1 to 256c325 Compare November 27, 2023 09:19
@ty-dc ty-dc force-pushed the e2e/optimization branch 12 times, most recently from c8a1245 to 9d50532 Compare November 28, 2023 10:56
@ty-dc
Copy link
Collaborator Author

ty-dc commented Nov 28, 2023

CI 一直失败的原因,替换spiderdoctor 为 kdoctor 后,在单独 ipv6 环境下,将 kdoctor-agent pod 重启后,该 Pod 在一定时间内会反复重启(访问 api-server 失败),导致执行 netreach 任务从 pod 中访问 clusterIP 时,会失败。

现在引用 kdoctor 的 agentSpec ,生成新的 Pod 进行测试。不再重启原本的 kdoctor-agent Pod,问题得到解决。

@ty-dc ty-dc removed pr/not-ready not ready for merging do-not-merge/waiting labels Nov 28, 2023
@ii2day
Copy link
Member

ii2day commented Nov 28, 2023

CI 一直失败的原因,替换spiderdoctor 为 kdoctor 后,在单独 ipv6 环境下,将 kdoctor-agent pod 重启后,该 Pod 在一定时间内会反复重启(访问 api-server 失败),导致执行 netreach 任务从 pod 中访问 clusterIP 时,会失败。

现在引用 kdoctor 的 agentSpec ,生成新的 Pod 进行测试。不再重启原本的 kdoctor-agent Pod,问题得到解决。

企业微信截图_6d000426-2011-467b-a5e6-0e723e8955fa
v6 环境访问 cluster ip 的延迟很高,导致 kdoctor 访问 apiserver 的 service 延迟也高,导致重启

@weizhoublue weizhoublue merged commit 7df1ad5 into spidernet-io:main Nov 28, 2023
40 checks passed
@ty-dc ty-dc mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/none no release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace spiderdoctor used in ci with kdoctor
3 participants