-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: Optimize installation and replacement of kdoctor #2648
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2648 +/- ##
==========================================
- Coverage 81.06% 81.00% -0.06%
==========================================
Files 49 49
Lines 5339 5339
==========================================
- Hits 4328 4325 -3
- Misses 854 856 +2
- Partials 157 158 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
b500b6a
to
2871f1c
Compare
2871f1c
to
b632f53
Compare
test/Makefile.defs
Outdated
@@ -41,7 +41,7 @@ INSTALL_MACVLAN ?= true | |||
|
|||
INSTALL_MULTUS ?= true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个变量 是否已经不需要了 ?
test/Makefile.defs
Outdated
INSTALL_NETTOOLS ?= false | ||
|
||
INSTALL_SPIDERDOCTOR ?= true | ||
INSTALL_KDOCTOR ?= true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
对本本地开发人员,这个默认也是不需要的
Makefile
Outdated
@@ -308,7 +308,7 @@ e2e_init: | |||
|
|||
.PHONY: e2e_init_underlay | |||
e2e_init_underlay: | |||
$(QUIET) make e2e_init -e INSTALL_OVERLAY_CNI=false -e E2E_SPIDERPOOL_ENABLE_SUBNET=true | |||
$(QUIET) make e2e_init -e INSTALL_OVERLAY_CNI=false -e E2E_SPIDERPOOL_ENABLE_SUBNET=true -e INSTALL_KRUISE=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
希望 e2e_init_underlay 是本地开发,精简的
因此,INSTALL_KRUISE=true 等变量 应该是 github action 代码中打开 ,而不是这
77bcca8
to
aad8466
Compare
aad8466
to
080fb4e
Compare
pr-ci 识别不到我修改的这几个变量呢?能怎么修下... @weizhoublue
手动通过 action 触发,正常。 |
080fb4e
to
f6323a3
Compare
先往 main 合入 action 的修改 即可 验证本 pr |
9ff5af1
to
256c325
Compare
c8a1245
to
9d50532
Compare
CI 一直失败的原因,替换spiderdoctor 为 kdoctor 后,在单独 ipv6 环境下,将 kdoctor-agent pod 重启后,该 Pod 在一定时间内会反复重启(访问 api-server 失败),导致执行 netreach 任务从 pod 中访问 clusterIP 时,会失败。 现在引用 kdoctor 的 agentSpec ,生成新的 Pod 进行测试。不再重启原本的 kdoctor-agent Pod,问题得到解决。 |
Signed-off-by: tao.yang <[email protected]>
9d50532
to
79887e7
Compare
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2191 #2446
Special notes for your reviewer: