docs typo: annotations is incorrectly written as labels #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ty-dc
requested review from
weizhoublue,
windsonsea and
cyclinder
as code owners
cyclinder
reviewed
Dec 2, 2024
| @@ -458,7 +458,7 @@ | |||
| metadata: | |||
| name: gpu1-sriov | |||
| namespace: spiderpool | |||
| labels: | |||
| annotations: | |||
There was a problem hiding this comment.
顺便默认 value 也改成 rdma-network, 这个之前和 kebe 约定过
Signed-off-by: ty-dc <[email protected]>
ty-dc
force-pushed
the
fix/webhook-docs
branch
from
e8d904d to
b37d7e1
Compare
weizhoublue
approved these changes
Dec 2, 2024
cyclinder
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
Notice:
"release/none"
"release/bug"
"release/feature"
What issue(s) does this PR fix:
Fixes #
Special notes for your reviewer: