Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs typo: annotations is incorrectly written as labels #4350

Merged
merged 1 commit into from
Dec 3, 2024
+12 −12
Merged

docs typo: annotations is incorrectly written as labels #4350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/usage/install/ai/get-started-macvlan-zh_CN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,8 +458,8 @@
metadata:
name: gpu1-sriov
namespace: spiderpool
labels:
cni.spidernet.io/rdma-resource-inject: gpu-network
annotations:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

顺便默认 value 也改成 rdma-network, 这个之前和 kebe 约定过

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

cni.spidernet.io/rdma-resource-inject: rdma-network
spec:
cniType: macvlan
macvlan:
Expand All @@ -478,7 +478,7 @@
template:
metadata:
annotations:
cni.spidernet.io/rdma-resource-inject: gpu-network
cni.spidernet.io/rdma-resource-inject: rdma-network
```

> 注意：使用 webhook 自动注入网络资源功能时，不能为应用添加其他网络配置注解(如 `k8s.v1.cni.cncf.io/networks` 和 `ipam.spidernet.io ippools`等)，否则会影响资源自动注入功能。
Expand Down
6 changes: 3 additions & 3 deletions docs/usage/install/ai/get-started-macvlan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,8 +456,8 @@ In the steps above, we demonstrated how to use SR-IOV technology to provide RDMA
metadata:
name: gpu1-sriov
namespace: spiderpool
labels:
cni.spidernet.io/rdma-resource-inject: gpu-network
annotations:
cni.spidernet.io/rdma-resource-inject: rdma-network
spec:
cniType: macvlan
macvlan:
Expand All @@ -476,7 +476,7 @@ In the steps above, we demonstrated how to use SR-IOV technology to provide RDMA
template:
metadata:
annotations:
cni.spidernet.io/rdma-resource-inject: gpu-network
cni.spidernet.io/rdma-resource-inject: rdma-network
```

> Note: When using the webhook automatic injection of network resources feature, do not add other network configuration annotations (such as `k8s.v1.cni.cncf.io/networks` and `ipam.spidernet.io/ippools`) to the application, as it will affect the automatic injection of resources.
Expand Down
6 changes: 3 additions & 3 deletions docs/usage/install/ai/get-started-sriov-zh_CN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,8 +645,8 @@ Spiderpool 使用了 [sriov-network-operator](https://github.com/k8snetworkplumb
metadata:
name: gpu1-sriov
namespace: spiderpool
labels:
cni.spidernet.io/rdma-resource-inject: gpu-network
annotations:
cni.spidernet.io/rdma-resource-inject: rdma-network
spec:
cniType: sriov
sriov:
Expand All @@ -664,7 +664,7 @@ Spiderpool 使用了 [sriov-network-operator](https://github.com/k8snetworkplumb
template:
metadata:
annotations:
cni.spidernet.io/rdma-resource-inject: gpu-network
cni.spidernet.io/rdma-resource-inject: rdma-network
```

> 注意：使用 webhook 自动注入网络资源功能时，不能为应用添加其他网络配置注解(如 `k8s.v1.cni.cncf.io/networks` 和 `ipam.spidernet.io ippools`等)，否则会影响资源自动注入功能。
Expand Down
6 changes: 3 additions & 3 deletions docs/usage/install/ai/get-started-sriov.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,8 +646,8 @@ In the steps above, we demonstrated how to use SR-IOV technology to provide RDMA
metadata:
name: gpu1-sriov
namespace: spiderpool
labels:
cni.spidernet.io/rdma-resource-inject: gpu-network
annotations:
cni.spidernet.io/rdma-resource-inject: rdma-network
spec:
cniType: sriov
sriov:
Expand All @@ -665,7 +665,7 @@ In the steps above, we demonstrated how to use SR-IOV technology to provide RDMA
template:
metadata:
annotations:
cni.spidernet.io/rdma-resource-inject: gpu-network
cni.spidernet.io/rdma-resource-inject: rdma-network
```

> Note: When using the webhook automatic injection of network resources feature, do not add other network configuration annotations (such as `k8s.v1.cni.cncf.io/networks` and `ipam.spidernet.io/ippools`) to the application, as it will affect the automatic injection of resources.
Expand Down
Loading