Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: one NIC's IP pool shortage depleted IPs of other NICs in a multi-NIC setup. #4382

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

weizhoublue
Copy link
Collaborator

robot cherry pick PR #4379 from ty-dc,to branch release-v1.0, action https://github.com/spidernet-io/spiderpool/actions/runs/12270989004 , commits f9feb6b

Fix:  one NIC's IP pool shortage depleted IPs of other NICs in a multi-NIC setup.
Signed-off-by: robot <[email protected]>
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.45%. Comparing base (9eeb019) to head (970534d).
Report is 2 commits behind head on release-v1.0.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v1.0    #4382      +/-   ##
================================================
- Coverage         79.55%   79.45%   -0.10%     
================================================
  Files                51       51              
  Lines              5776     5783       +7     
================================================
  Hits               4595     4595              
- Misses             1016     1024       +8     
+ Partials            165      164       -1     
Flag Coverage Δ
unittests 79.45% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/ippoolmanager/ippool_manager.go 84.61% <100.00%> (-2.03%) ⬇️

@weizhoublue weizhoublue merged commit 6e383aa into release-v1.0 Dec 11, 2024
54 of 55 checks passed
@weizhoublue weizhoublue deleted the robot/cherrypick/pr4379/release-v1.0 branch December 11, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants