Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binaries built without CGO will not use BoringCrypto as expected #76

Open
strideynet opened this issue Jan 2, 2025 · 1 comment
Open
Labels
good first issue Good for newcomers

Comments

@strideynet
Copy link
Contributor

hack/build-spike.sh:

CGO_ENABLED=0 GOEXPERIMENT=boringcrypto go build -o keeper ./app/keeper/cmd/main.go
CGO_ENABLED=1 GOEXPERIMENT=boringcrypto go build -o nexus ./app/nexus/cmd/main.go
CGO_ENABLED=0 GOEXPERIMENT=boringcrypto go build -o spike ./app/spike/cmd/main.go
CGO_ENABLED=0 GOEXPERIMENT=boringcrypto go build -o demo ./app/demo/cmd/main.go

Here, we specify CGO_ENABLED=0 for the building of most binaries, but, we also specify GOEXPERIMENT=boringcrypto. This combination causes the binary to be silently built without boringcrypto!

We should adjust all binaries to be built using CGO, or, build them without specifying boringcrypto.

I'd suggest that if we're not immediately aiming to be FIPS-compatible, we may want to drop boringcrypto, and wait for golang/go#69536

@v0lkan v0lkan added the good first issue Good for newcomers label Feb 18, 2025
@v0lkan
Copy link
Contributor

v0lkan commented Feb 18, 2025

All good suggestions.

We can at least make all of the binaries CGO enabled as a low hanging fruit maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants