Benchmark jobs fail if benchmarks fail but always post results (#798)

spiraldb · Sep 12, 2024 · a79eba3 · a79eba3
1 parent d1ec381
commit a79eba3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/.github/workflows/bench-pr.yml b/.github/workflows/bench-pr.yml
@@ -33,9 +33,11 @@ jobs:
           version: v1.0.0
 
       - name: Run benchmark
+        shell: bash
         run: cargo bench --bench tpch_benchmark -- --output-format bencher | tee output.txt
 
       - name: Store benchmark result
+        if: '!cancelled()'
         uses: benchmark-action/github-action-benchmark@v1
         with:
           name: Vortex benchmarks

diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml
@@ -25,9 +25,11 @@ jobs:
           version: v1.0.0
 
       - name: Run benchmark
+        shell: bash
         run: cargo bench --bench tpch_benchmark -- --output-format bencher | tee output.txt
 
       - name: Store benchmark result
+        if: '!cancelled()'
         uses: benchmark-action/github-action-benchmark@v1
         with:
           name: Vortex benchmarks