From a79eba362bc32f9f762253b3c249f6bebd4eff1a Mon Sep 17 00:00:00 2001 From: Robert Kruszewski Date: Thu, 12 Sep 2024 14:23:26 +0100 Subject: [PATCH] Benchmark jobs fail if benchmarks fail but always post results (#798) --- .github/workflows/bench-pr.yml | 2 ++ .github/workflows/bench.yml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/.github/workflows/bench-pr.yml b/.github/workflows/bench-pr.yml index b0aaecb411..c900950357 100644 --- a/.github/workflows/bench-pr.yml +++ b/.github/workflows/bench-pr.yml @@ -33,9 +33,11 @@ jobs: version: v1.0.0 - name: Run benchmark + shell: bash run: cargo bench --bench tpch_benchmark -- --output-format bencher | tee output.txt - name: Store benchmark result + if: '!cancelled()' uses: benchmark-action/github-action-benchmark@v1 with: name: Vortex benchmarks diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml index 026ca509a8..9cea64782f 100644 --- a/.github/workflows/bench.yml +++ b/.github/workflows/bench.yml @@ -25,9 +25,11 @@ jobs: version: v1.0.0 - name: Run benchmark + shell: bash run: cargo bench --bench tpch_benchmark -- --output-format bencher | tee output.txt - name: Store benchmark result + if: '!cancelled()' uses: benchmark-action/github-action-benchmark@v1 with: name: Vortex benchmarks