From a4450bf999cbe2e803d8f05397d79bba99945016 Mon Sep 17 00:00:00 2001 From: Gijs van Veen Date: Fri, 24 Mar 2023 14:39:30 +0100 Subject: [PATCH 1/2] "Fix" buffered as list tests --- .../commonTest/kotlin/utils/BufferedAsListChannelTest.kt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/base/src/commonTest/kotlin/utils/BufferedAsListChannelTest.kt b/base/src/commonTest/kotlin/utils/BufferedAsListChannelTest.kt index 2cfed2488..e55274331 100644 --- a/base/src/commonTest/kotlin/utils/BufferedAsListChannelTest.kt +++ b/base/src/commonTest/kotlin/utils/BufferedAsListChannelTest.kt @@ -36,13 +36,13 @@ import kotlin.time.Duration.Companion.milliseconds class BufferedAsListChannelTest { @Test - fun testEqualChannel() = testBufferedAsListChannel(10.milliseconds, 10.milliseconds, 50..100) + fun testEqualChannel() = testBufferedAsListChannel(10.milliseconds, 10.milliseconds, 1..100) @Test - fun testSlowToProduceChannel() = testBufferedAsListChannel(10.milliseconds, 1.milliseconds, 50..100) + fun testSlowToProduceChannel() = testBufferedAsListChannel(10.milliseconds, 1.milliseconds, 1..100) @Test - fun testSlowToConsumeChannel() = testBufferedAsListChannel(1.milliseconds, 10.milliseconds, 5..20) + fun testSlowToConsumeChannel() = testBufferedAsListChannel(1.milliseconds, 10.milliseconds, 1..100) @Test fun testCancel() = runBlocking { From 0b6597c9ad7ec715a88eac55da2bbb219f64d2f4 Mon Sep 17 00:00:00 2001 From: Gijs van Veen Date: Fri, 24 Mar 2023 14:49:48 +0100 Subject: [PATCH 2/2] Added todo notes --- .../commonTest/kotlin/utils/BufferedAsListChannelTest.kt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/base/src/commonTest/kotlin/utils/BufferedAsListChannelTest.kt b/base/src/commonTest/kotlin/utils/BufferedAsListChannelTest.kt index e55274331..0d52c509d 100644 --- a/base/src/commonTest/kotlin/utils/BufferedAsListChannelTest.kt +++ b/base/src/commonTest/kotlin/utils/BufferedAsListChannelTest.kt @@ -36,13 +36,13 @@ import kotlin.time.Duration.Companion.milliseconds class BufferedAsListChannelTest { @Test - fun testEqualChannel() = testBufferedAsListChannel(10.milliseconds, 10.milliseconds, 1..100) + fun testEqualChannel() = testBufferedAsListChannel(10.milliseconds, 10.milliseconds, 1..100) // TODO: Should be in a range of about 99-100 but tests on CI prove flaky @Test - fun testSlowToProduceChannel() = testBufferedAsListChannel(10.milliseconds, 1.milliseconds, 1..100) + fun testSlowToProduceChannel() = testBufferedAsListChannel(10.milliseconds, 1.milliseconds, 1..100) // TODO: Should be in a range of about 5-15 but tests on CI prove flaky @Test - fun testSlowToConsumeChannel() = testBufferedAsListChannel(1.milliseconds, 10.milliseconds, 1..100) + fun testSlowToConsumeChannel() = testBufferedAsListChannel(1.milliseconds, 10.milliseconds, 1..100) // TODO: Should be in a range of about 5-15 but tests on CI prove flaky @Test fun testCancel() = runBlocking {