Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultKalugaDate.copy is incorrect JS #767

Open
vpodlesnyak opened this issue Apr 29, 2024 · 1 comment
Open

DefaultKalugaDate.copy is incorrect JS #767

vpodlesnyak opened this issue Apr 29, 2024 · 1 comment
Assignees
@vpodlesnyak

Comments

@vpodlesnyak
Copy link
Contributor

Describe the bug
Using copy resets time close to 1970-01-01 because JS code uses milliseconds instead of millisecondsSinceEpoch

To Reproduce
Use copy in JS code

Expected behavior
Using copy yields a correct copy of a date
@vpodlesnyak vpodlesnyak self-assigned this Apr 29, 2024
@vpodlesnyak vpodlesnyak added 1.4.0 Expected in the 1.4.0 release and removed 1.4.0 Expected in the 1.4.0 release labels Apr 29, 2024
@vpodlesnyak
Copy link
Contributor Author

as it turns out the whole KalugaDate in JS is incorrect as setters do nothing and compareTo is implemented incorrectly

@vpodlesnyak vpodlesnyak mentioned this issue Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vpodlesnyak vpodlesnyak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vpodlesnyak