Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some pending PRs... #255

Open
ChristopherJohnston opened this issue Oct 21, 2024 · 2 comments
Open

some pending PRs... #255

ChristopherJohnston opened this issue Oct 21, 2024 · 2 comments

Comments

@ChristopherJohnston
Copy link
Contributor

ChristopherJohnston commented Oct 21, 2024

@scastiel - nice one making all the updates to tRPC - it has a really good feel to it. I've been catching up some of my PRs to get in line with this approach. See: #165, #166, #203, #252, which are ready to review/merge

#161 I've closed for now as I think it needs more thought

203 is now updated

@scastiel
Copy link
Member

Hey @ChristopherJohnston, I understand if you feel I'm ignoring your PRs, but I'm not 😉

It's just they require a bit more work from me than PR adding translations, but I can see how valuable they are! I'll try to find some time this week to review and merge them!

@ChristopherJohnston
Copy link
Contributor Author

ChristopherJohnston commented Oct 21, 2024

no it's fine - I can see that the changes you're making are way more important! I am just conscious that the code base is changing a lot at the moment and it would be easier (from my perspective at least 😄) to merge then update rather than me getting them in sync. That said, it's a good way of me getting up to speed with all of the great updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants