Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft Teams: Just a heads up - Adding new actions to Microsoft Teams SOAR apps #20

Merged
merged 24 commits into from
Nov 21, 2024
Merged

Microsoft Teams: Just a heads up - Adding new actions to Microsoft Teams SOAR apps #20

merged 24 commits into from
Nov 21, 2024

Conversation

pdros-splunk
Copy link
Contributor

Please ensure your pull request (PR) adheres to the following guidelines:

  • Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • Testing of all the changes has been performed (for bug fixes / features)
  • The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
  • Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
  • Verify all checks are passing.
  • Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
  • Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe):

Security Considerations (REQUIRED)

  • If you are exposing any endpoints using a REST handler,
    please document them in the manual_readme_content.md.
  • If this is a new connector or you are adding new actions
    • Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
      with the service that the connector is integrating with.
    • If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.
  • Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
  • Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
    the Vault API.
  • Are you are marking code to be ignored by Semgrep with nosemgrep?
    If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

  • Adding 4 new actions to connector send chat message, get channel message, get chat message, get response message

Thanks for contributing!

@splunk-soar-connectors-bot
Copy link
Collaborator

Thank you for your submission! We have a total of 19 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can.

@splunk-soar-connectors-bot
Copy link
Collaborator

@pdros-splunk Static Tests results for commit 9d98e81 - https://drive.google.com/file/d/1yk27mvq_RKclROBLDUDKbG_EY-lTz-Yy/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@pdros-splunk Compile Tests results for commit 9d98e81 - https://drive.google.com/file/d/15wb_6e7YGvYVnKTqjGSUpMon526sfQtb/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit d3e28c9 - https://drive.google.com/file/d/1YZlXIurJjIQGQP_XCQHX7XXOxHcVWNQW/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit d3e28c9 - https://drive.google.com/file/d/18bGf5_jRsN1IEHuFtNCP8yNeeORPI2B8/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit 2e97a22 - https://drive.google.com/file/d/1a1Y_OcUsDj31uLRyohbEr_AZMNK82wTk/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit 2e97a22 - https://drive.google.com/file/d/1eCDldKZPHrN5HKMgDC_fRQ6jKF3X0NHq/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit 1b4d391 - https://drive.google.com/file/d/1QeB8-lkPtwB1XUJCAuhDHViNa6bja_3i/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit 1b4d391 - https://drive.google.com/file/d/1k_5ciLHRi-mEq4ENMfq63Kp2wHSoZ73s/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit ddfd606 - https://drive.google.com/file/d/1uHlPunF0lAleF26KNc9fnKKVQT0lOG9i/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit ddfd606 - https://drive.google.com/file/d/1ArjJOEJEHJoCjR3MxnHI4PAcLVRdNAqM/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit 23d8180 - https://drive.google.com/file/d/1Nhz2vgGa0_w1ZHCG4uetohYa0abWDNQ6/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit 23d8180 - https://drive.google.com/file/d/1Ul03yA4aC7CJEqrQd4TkPyT_iEN7ZkW6/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit 021951e - https://drive.google.com/file/d/11EhGmdbfdnRtf3Vhou_tkifSmYEo4qHC/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit 021951e - https://drive.google.com/file/d/1Hmm_vcv6m9UUBbjwHxThgeng5C89pkgz/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit 79a0448 - https://drive.google.com/file/d/1o3JFw31H74_zeqPyIY3dBOTDiV88gYBT/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit 79a0448 - https://drive.google.com/file/d/1GsT1kMlycpBvC2wFXWcXR0n7sarfXRrI/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit ef4a07f - https://drive.google.com/file/d/10MpLd3ZYmh32gozVXDMYuyYqqLXjgjI8/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit e408d30 - https://drive.google.com/file/d/1N6kymKWvX59vO_o_tt82w6s36RNmmf2Y/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit e408d30 - https://drive.google.com/file/d/15RGyBetn6cw5FgCAOfHGv8n6l1HLHJMI/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit f69d028 - https://drive.google.com/file/d/18bo20GwWtJQO7TKAqIqP0bAylIfQFBbG/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit f69d028 - https://drive.google.com/file/d/11zeAtA30fLrAwhO4SySMd1lfLyp58zmL/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit bd43e54 - https://drive.google.com/file/d/1wg4qzEI0JtazEbDS7bgdOJuXFeBvMNbD/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit bd43e54 - https://drive.google.com/file/d/1XFm_C5Sflt9qqinnH9SqJPPbq8px1x4j/view?usp=drivesdk

bb-splunk
bb-splunk reviewed Nov 12, 2024
View reviewed changes
manual_readme_content.md Outdated Show resolved Hide resolved
microsoftteams_connector.py Show resolved Hide resolved
microsoftteams_connector.py Outdated Show resolved Hide resolved
@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit 336db10 - https://drive.google.com/file/d/1S2ElmQHteTmxuwhTu_Cv1cL5lTUd289t/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit 336db10 - https://drive.google.com/file/d/19BKCRSdq5bU_YzxxTteU1CroNUrHvTV7/view?usp=drivesdk

bb-splunk
bb-splunk approved these changes Nov 15, 2024
View reviewed changes
manual_readme_content.md Outdated Show resolved Hide resolved
microsoftteams_connector.py Outdated Show resolved Hide resolved
@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit bb2372d - https://drive.google.com/file/d/1HOGqkuAcRjDGs3M-hTZ5XYaI4_Km6KEM/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit bb2372d - https://drive.google.com/file/d/1hz4IkRLVVhb8gLTlkVTH2lUEvw0H1kxj/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit b27d8f8 - https://drive.google.com/file/d/1hHkqC4LsdGi1AMToENT25xMXssicBpGa/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit b27d8f8 - https://drive.google.com/file/d/1NhgPKnoCleVdXYYIOXbasV2vamTgLl0D/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit bbab834 - https://drive.google.com/file/d/1zv4zbw0_-n5zjiAfTD7iCL6ZNpYAHrCh/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit bbab834 - https://drive.google.com/file/d/1RrDNd03oJ0Lz7wTHTWTp9y2-2mcKic49/view?usp=drivesdk

@ishans-crest ishans-crest merged commit 4652022 into splunk-soar-connectors:next Nov 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdelavadiya-crest gdelavadiya-crest gdelavadiya-crest left review comments

@stutib-crest stutib-crest stutib-crest approved these changes

@bb-splunk bb-splunk bb-splunk approved these changes

@ishans-crest ishans-crest ishans-crest approved these changes

@mmomin-crest mmomin-crest mmomin-crest approved these changes

Assignees
No one assigned
Labels
external-contributor PAPP-34355 splunk-supported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pdros-splunk @splunk-soar-connectors-bot @mmomin-crest @ishans-crest @bb-splunk @gdelavadiya-crest @stutib-crest