Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThreatDown Nebula: Code Style Update - Changing app name from 'Malwarebytes Cloud' to 'ThreatDown Nebula' #6

Merged
merged 22 commits into from
Mar 4, 2024
Merged

ThreatDown Nebula: Code Style Update - Changing app name from 'Malwarebytes Cloud' to 'ThreatDown Nebula' #6

merged 22 commits into from
Mar 4, 2024

Conversation

rskumar-mwb
Copy link
Contributor

@rskumar-mwb rskumar-mwb commented Jan 15, 2024 •
edited
Loading

Please ensure your pull request (PR) adheres to the following guidelines:

  • Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • Testing of all the changes has been performed (for bug fixes / features)
  • The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
  • Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
  • Verify all checks are passing.
  • Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
  • Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe):

Security Considerations (REQUIRED)

  • If you are exposing any endpoints using a REST handler,
    please document them in the manual_readme_content.md.
  • If this is a new connector or you are adding new actions
    • Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
      with the service that the connector is integrating with.
    • If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.
  • Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
  • Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
    the Vault API.
  • Are you are marking code to be ignored by Semgrep with nosemgrep?
    If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

  • Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

  • Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

  • Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

  • Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Thanks for contributing!

@splunk-soar-connectors-bot
Copy link
Collaborator

Thank you for your submission! We have a total of 21 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can.

@splunk-soar-connectors-bot
Copy link
Collaborator

@rskumar-mwb Static Tests results for commit 6df3e4d - https://drive.google.com/file/d/1nm2rOvrahSVR86MXTG0oLjNys0PFN0ED/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@rskumar-mwb Compile Tests results for commit 6df3e4d - https://drive.google.com/file/d/1qS9dlZEzi62WgZOtpqeHn-Pb5e3xhMya/view?usp=drivesdk

@rskumar-mwb rskumar-mwb changed the title Version 2.0.1 ThreatDown Nebula: Code Style Update - Changing app name from 'Malwarebytes Cloud' to 'ThreatDown Nebula' Jan 15, 2024
@splunk-soar-connectors-bot
Copy link
Collaborator

@rskumar-mwb Static Tests results for commit 74b7b4c - https://drive.google.com/file/d/17Xeb0OhPCqygP7micdgzrF5a66o7zA4m/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@rskumar-mwb Static Tests results for commit 301fa6c - https://drive.google.com/file/d/1C_Aqup0KMFxz0uswH5tKzt-xyt3l_BW_/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@rskumar-mwb Compile Tests results for commit 301fa6c - https://drive.google.com/file/d/1zRXraMEkCVkiclTsxdsn8vMyzLAcYpcC/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@rskumar-mwb Static Tests results for commit d921946 - https://drive.google.com/file/d/1HWdAEM0tuP3mW_S2m04vHzHm-whe28-p/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@rskumar-mwb Compile Tests results for commit d921946 - https://drive.google.com/file/d/1PA7Ds5AOzlR2J2LelaLwgPcWJglhnao6/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@szarembo-mwb Static Tests results for commit 278f065 - https://drive.google.com/file/d/1wibfq94L5aN4pvFhIdBxC6LMvKEYECkb/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@szarembo-mwb Compile Tests results for commit 278f065 - https://drive.google.com/file/d/1MwQGTwSkrndbCnAlqL4MuIOrTQk91RWs/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@mishalp-crest Static Tests results for commit 4c97f8f - https://drive.google.com/file/d/1FinlVDdwxNYFgIIP9P14o3vrHaxG7iZz/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@szarembo-mwb Compile Tests results for commit ed694bc - https://drive.google.com/file/d/17Il-X_lZB-C7LaqYZbqU_OMmBmPhDr2c/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@szarembo-mwb Static Tests results for commit 335e29c - https://drive.google.com/file/d/1TQ3lJ8NdkcRPnt27RzX6zsDWNnndIORC/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@szarembo-mwb Compile Tests results for commit 335e29c - https://drive.google.com/file/d/1QwH6n7chVSIU96x1CEGhdAqB-jpQO0Tx/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@mishalp-crest Static Tests results for commit 78b6021 - https://drive.google.com/file/d/1tX6eQ4B6OtTb3Na4ydFypaQUTWw_8FlP/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@mishalp-crest Compile Tests results for commit 78b6021 - https://drive.google.com/file/d/1Xj-ZAmQKR18To-UHnBroPffg9Y0JHCwC/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@mishalp-crest Static Tests results for commit 78b6021 - https://drive.google.com/file/d/1OEcVGQoBAa8U8uO6h7l5lKNra7aWU64v/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@mishalp-crest Static Tests results for commit 78b6021 - https://drive.google.com/file/d/14r5SrXHZ_-b0U-w7TAnQbG-WPYzRnHTm/view?usp=drivesdk

@mishalp-crest
Copy link
Contributor

@rskumar-mwb
Can you also change the repo's name so we can ensure there are no pipeline failures?

@splunk-soar-connectors-bot
Copy link
Collaborator

@mishalp-crest Static Tests results for commit 78b6021 - https://drive.google.com/file/d/1WVRYReYIAwYWWO8rG-1Cp9aZHtPHWvH-/view?usp=drivesdk

@rskumar-mwb
Copy link
Contributor Author

@mishalp-crest i have changed the repo name. Lmk if there’s any more changes needed from our end

@splunk-soar-connectors-bot
Copy link
Collaborator

@mishalp-crest Static Tests results for commit dd0fcca - https://drive.google.com/file/d/120dunitHfkoFsJ9bP3Eiyi3xqB6XRiTm/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@mishalp-crest Compile Tests results for commit dd0fcca - https://drive.google.com/file/d/1TwO1x8x5DBCVgM5e13tdHAnJEPJ4Eg1K/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@mishalp-crest Static Tests results for commit 166647e - https://drive.google.com/file/d/1Z6vaISQBf4UhYeZZyA87ktZSqI2iB9IT/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@mishalp-crest Compile Tests results for commit 166647e - https://drive.google.com/file/d/1I460eFdkKvTAE2QMjV_5427mEhtYX79n/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@mishalp-crest Static Tests results for commit 03b85e1 - https://drive.google.com/file/d/1bJwtsDYGbuKn4UZnuNIn9vVK9lWOKH6x/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@mishalp-crest Compile Tests results for commit 03b85e1 - https://drive.google.com/file/d/1zdiQaZdno6URP9dTThLy_mXH6z47WdPT/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@mishalp-crest Static Tests results for commit cc2934d - https://drive.google.com/file/d/1QafaaHYpjnhZnl4sXeZPz7tC--QARCol/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@mishalp-crest Compile Tests results for commit cc2934d - https://drive.google.com/file/d/1l6bNNrodAMMZqrdV17K6Gv_QCbwYpJ-n/view?usp=drivesdk

@mishalp-crest mishalp-crest merged commit 7b98c10 into splunk-soar-connectors:next Mar 4, 2024
4 checks passed
@rskumar-mwb
Copy link
Contributor Author

@mmomin-crest Do you know when this version will be released ?

@mishalp-crest
Copy link
Contributor

@rskumar-mwb
It's has been already released here
Just a change of name is pending
Might take 1-2 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szarembo-mwb szarembo-mwb szarembo-mwb left review comments

@hardik-crest hardik-crest hardik-crest approved these changes

@mmomin-crest mmomin-crest mmomin-crest approved these changes

Assignees
No one assigned
Labels
developer-supported external-contributor PAPP-32990
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rskumar-mwb @splunk-soar-connectors-bot @mishalp-crest @szarembo-mwb @mmomin-crest @hardik-crest