Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test & release_notes assume repo location #306

Open
0xC0FFEEEE opened this issue Oct 10, 2024 · 0 comments
Open

test & release_notes assume repo location #306

0xC0FFEEEE opened this issue Oct 10, 2024 · 0 comments

Comments

@0xC0FFEEEE
Copy link
Contributor

0xC0FFEEEE commented Oct 10, 2024

Both of the mentioned features assume that the repository exists in the same directory as the content, which may not be the case.

They both currently appear to be using different modules (pygit2 for test & git for release_notes) so the solution can't quite be a one size fits all approach today.

There should either be a repo_path config option, or both features aligned to use the same module such as pygit2, where something like the following could be used:

repo_path = pygit2.discover_repository(self.config.path)
repo = pygit2.Repository(path=str(repo_path))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant