Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Year is incorrect on OS with Japanese locale #2

Open
lwlwlwlw opened this issue Aug 4, 2023 · 1 comment
Open

Year is incorrect on OS with Japanese locale #2

lwlwlwlw opened this issue Aug 4, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@lwlwlwlw
Copy link

lwlwlwlw commented Aug 4, 2023

Year "2021" is shown as "0003" in Analyst on Windows 10 with Japanese locale.
Please fix this.
Thank you.

gantt-chart-year-incorrect-japanese-locale

@lwlwlwlw
Copy link
Author

lwlwlwlw commented Aug 4, 2023

The fix seems to be as below.

src\Components\header.ts

Line No.62
format: "yyyy",

change to
format: "YYYY",

The reason is "yyyy" produces Era year which means 0003/0004/0005 (Reiwa Era) for 2021/2022/2023 on Japanese locale.

I can not push my code or make pull request due to some reasons.
Please fix this.
Thank you.

@arnaudspotfire arnaudspotfire added the bug Something isn't working label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants