resolvers in resolveXYScale
should recursively traverse children
tree
#36
Labels
resolveXYScale
should recursively traverse children
tree
#36
The new code in
0.2.1
is improving but has a significant regression - All of the resolvers inresolveXYScales
used to recursively check the component's children to find the necessary props. However @thehindenburg 's newmapOverChildren
, while being a nicer abstraction, does not do recursion - it only maps over an element's direct children.Recursion is necessary IMHO because we want to support the use case of the user having intermediate layer components between
XYPlot
and their charts, eg.:Without recursion, this would never try to resolve anything on the actual chart components, it would stop at CustomChartWrapper. We should improve the general resolution functions in
resolveXYScales
to handle this caseThe text was updated successfully, but these errors were encountered: