Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init #1

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Init #1

wants to merge 32 commits into from

Conversation

spqrcor
Copy link
Owner

@spqrcor spqrcor commented Sep 5, 2024

No description provided.

Пешков Дмитрий added 2 commits September 5, 2024 20:22
@spqrcor spqrcor requested a review from ekubyshin September 16, 2024 11:00
@spqrcor
Copy link
Owner Author

spqrcor commented Sep 16, 2024

Черновой вариант, без тестов

internal/server/server.go Outdated Show resolved Hide resolved
internal/server/server.go Outdated Show resolved Hide resolved
cmd/gophermart/main.go Outdated Show resolved Hide resolved
cmd/gophermart/main.go Outdated Show resolved Hide resolved
internal/services/order.go Show resolved Hide resolved
internal/handlers/handlers.go Outdated Show resolved Hide resolved
internal/handlers/handlers.go Outdated Show resolved Hide resolved
internal/logger/logger.go Outdated Show resolved Hide resolved
internal/server/middleware.go Outdated Show resolved Hide resolved
Пешков Дмитрий added 2 commits September 21, 2024 15:25
@spqrcor
Copy link
Owner Author

spqrcor commented Sep 21, 2024

Пробежался по замечаниям, внес.

Большой вопрос по unit тестам, я сегодня начал писать, как лучше максимально использовать моки или реальные объекты? Если моки то получается, нужно вернуть интерфейсы

cmd/gophermart/main.go Outdated Show resolved Hide resolved
cmd/gophermart/main.go Outdated Show resolved Hide resolved
internal/authenticate/authenticate.go Outdated Show resolved Hide resolved
internal/client/order.go Outdated Show resolved Hide resolved
internal/client/order.go Show resolved Hide resolved
internal/server/gzip.go Outdated Show resolved Hide resolved
internal/server/server.go Outdated Show resolved Hide resolved
internal/services/order.go Outdated Show resolved Hide resolved
internal/workers/order.go Outdated Show resolved Hide resolved
internal/workers/order.go Outdated Show resolved Hide resolved
cmd/gophermart/main.go Show resolved Hide resolved
cmd/gophermart/main.go Show resolved Hide resolved
cmd/gophermart/main.go Show resolved Hide resolved
cmd/gophermart/main.go Show resolved Hide resolved
cmd/gophermart/main.go Show resolved Hide resolved
internal/authenticate/authenticate.go Show resolved Hide resolved
internal/config/config.go Show resolved Hide resolved
internal/db/connector.go Show resolved Hide resolved
internal/db/connector.go Show resolved Hide resolved
internal/services/user.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants