Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite: Convert directives to components #371

Open
11 of 28 tasks
Tracked by #374
arildm opened this issue Jun 17, 2024 · 0 comments
Open
11 of 28 tasks
Tracked by #374

Rewrite: Convert directives to components #371

arildm opened this issue Jun 17, 2024 · 0 comments
Labels
maintenance Oiling the gears, preventing future problems
Milestone
Rewrite to Vue

Comments

@arildm
Copy link
Member

arildm commented Jun 17, 2024 •
edited
Loading

In AngularJS, Components are more self-contained than Directives. They enforce vertical rather than horizontal dependency. Also, the same concept exists in Vue which makes migration easier.

Some cases are not well translated into components, and should be handled some other way.

  • kwicWord
  • tabHash
  • escaper
  • searchSubmit
  • meter
  • popper
  • tabSpinner
  • tabPreloader
  • clickCover
  • toBody
  • warning
  • typeaheadClickOpen
  • timeInterval
  • reduceSelect
  • globalFilters
  • globalFilter
  • mapCtrl
  • newsDesk
  • textReaderCtrl
  • textReader
  • compareCtrl
  • exampleCtrl
  • kwicCtrl
  • statsResultCtrl
  • graphCtrl
  • wordpicCtrl
  • scrollToStart

And

  • search history, which is not even consolidated into a directive, but spread across several files (history.js, services.js, main.ts, searchtabs.js); related:
@arildm arildm added the maintenance Oiling the gears, preventing future problems label Jun 17, 2024
@arildm arildm mentioned this issue Jun 17, 2024
Open
5 tasks
@arildm arildm added this to the Rewrite to Vue milestone Jul 11, 2024
@arildm arildm mentioned this issue Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Oiling the gears, preventing future problems
Projects
None yet
Milestone
Rewrite to Vue
Development

No branches or pull requests
1 participant
@arildm