From 3a9875be2613a2bee3f7c077db659f6980f4a71d Mon Sep 17 00:00:00 2001
From: Kristoffer Andersson <kristoffer.andersson@gu.se>
Date: Wed, 27 Mar 2024 10:46:01 +0100
Subject: [PATCH] chore: add support for python 3.8

---
 .github/workflows/check.yml                  | 8 ++++----
 .github/workflows/release-viklofg-sweocr.yml | 6 +++---
 .github/workflows/test.yml                   | 6 +++---
 ocr-correction-viklofg-sweocr/pyproject.toml | 2 +-
 pyproject.toml                               | 2 +-
 ruff.toml                                    | 2 +-
 6 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
index 5d11d6e..c11b683 100644
--- a/.github/workflows/check.yml
+++ b/.github/workflows/check.yml
@@ -11,7 +11,7 @@ permissions:
   contents: read
 
 env:
-  MINIMUM_PYTHON_VERSION: "3.9"
+  MINIMUM_PYTHON_VERSION: "3.8"
 
 # If new code is pushed to a PR branch, then cancel in progress workflows for that PR. Ensures that
 # we don't waste CI time, and returns results quicker https://github.com/jonhoo/rust-ci-conf/pull/5
@@ -22,7 +22,7 @@ concurrency:
 jobs:
   fmt:
     runs-on: ubuntu-latest
-    name: ubuntu / 3.9 / fmt
+    name: ubuntu / 3.8 / fmt
     steps:
       - uses: actions/checkout@v4
         with:
@@ -49,7 +49,7 @@ jobs:
         run: make check-fmt
   lint:
     runs-on: ubuntu-latest
-    name: ubuntu / 3.9 / lint
+    name: ubuntu / 3.8 / lint
     steps:
       - uses: actions/checkout@v4
         with:
@@ -72,7 +72,7 @@ jobs:
         run: make lint
   type-check:
     runs-on: ubuntu-latest
-    name: ubuntu / 3.9 / type-check
+    name: ubuntu / 3.8 / type-check
     steps:
       - uses: actions/checkout@v4
         with:
diff --git a/.github/workflows/release-viklofg-sweocr.yml b/.github/workflows/release-viklofg-sweocr.yml
index 339a57f..462e89f 100644
--- a/.github/workflows/release-viklofg-sweocr.yml
+++ b/.github/workflows/release-viklofg-sweocr.yml
@@ -16,13 +16,13 @@ permissions:
   contents: read
 
 env:
-  MINIMUM_PYTHON_VERSION: "3.9"
+  MINIMUM_PYTHON_VERSION: "3.8"
 
 jobs:
   build:
     # This action builds distribution files for upload to PyPI
 
-    name: ubuntu / 3.9 / build
+    name: ubuntu / 3.8 / build
     runs-on: ubuntu-latest
     steps:
       #----------------------------------------------
@@ -60,7 +60,7 @@ jobs:
     # This action runs the test suite on the built artifact in the `build` action.
     # The default is to run this in ubuntu, macos and windows
 
-    name: ${{ matrix.os }} / 3.9 / test built artifact
+    name: ${{ matrix.os }} / 3.8 / test built artifact
     needs: [build]
 
     strategy:
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 249848c..c75133a 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -15,7 +15,7 @@ permissions:
   contents: read
 
 env:
-  MINIMUM_PYTHON_VERSION: "3.9"
+  MINIMUM_PYTHON_VERSION: "3.8"
 
 jobs:
 
@@ -32,7 +32,7 @@ jobs:
         os: [ubuntu] 
         python-version:
           # remove the unused versions
-          - "3.9"
+          - "3.8"
           - "3.10"
           - "3.11"
           - "3.12" 
@@ -87,7 +87,7 @@ jobs:
     #
     
     runs-on: ubuntu-latest
-    name: ubuntu / 3.9 / minimal-versions
+    name: ubuntu / 3.8 / minimal-versions
     steps:
       - uses: actions/checkout@v4
         with:
diff --git a/ocr-correction-viklofg-sweocr/pyproject.toml b/ocr-correction-viklofg-sweocr/pyproject.toml
index 97a7359..03f1027 100644
--- a/ocr-correction-viklofg-sweocr/pyproject.toml
+++ b/ocr-correction-viklofg-sweocr/pyproject.toml
@@ -8,7 +8,7 @@ authors = [
 dependencies = ["sparv-pipeline >=5.2.0", "transformers>=4.34.1"]
 license = { text = "MIT" }
 readme = "README.md"
-requires-python = ">=3.9"
+requires-python = ">=3.8"
 classifiers = [
     "Development Status :: 3 - Alpha",
     # "Development Status :: 4 - Beta",
diff --git a/pyproject.toml b/pyproject.toml
index f9a04c8..054bb7a 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -1,7 +1,7 @@
 [project]
 name = "sparv-sbx-ocr-correction-workspace"
 dependencies = []
-requires-python = ">=3.9,<3.12"
+requires-python = ">=3.8"
 version = "0.0.0"
 
 [tool.pdm.dev-dependencies]
diff --git a/ruff.toml b/ruff.toml
index f786827..31a5169 100644
--- a/ruff.toml
+++ b/ruff.toml
@@ -1,4 +1,4 @@
-target-version = "py39"
+target-version = "py38"
 
 [lint]
 select = [