Character set windows-1252 should be CP1252 under Unix

[supercosh]

In /src/PaymentPart/Output/FpdfOutput/FpdfOutput.php, the following code is found:

return iconv('UTF-8', 'windows-1252', $text) ?: '';

Under unix, the character set should be called "CP1252", since "windows-1252" is unknown on most systems. Also I'm not sure if the code is correct, since the funktion name is "toUtf8", but what the code does, is to convert "from" UTF8.

The occurence of "windows-1252" is in several files.

[sprain]

Thanks for reporting.

Do you experience any problems because of this or is it just "cosmetics"?

[supercosh]

It just throws a PHP warnings every time a QR bill is created; the generated qr bill however seems to be valid. So it's not a severe problem, it just got me curious because of the growing logs. A solution could perhaps be to get a list of the character sets on the system and chose one of them?

[sprain]

Could you post the exacting warning that you get? This might help to improve this.

[supercosh]

Here's the warning

2024-01-26 15:54:25 warning: iconv(): Wrong encoding, conversion from "UTF-8" to "windows-1252" is not allowed
Trace:
iconv [internal], line ??
Sprain\SwissQrBill\PaymentPart\Output\TcPdfOutput\TcPdfOutput::toUtf8() /httpdocs/vendor/sprain/swiss-qr-bill/src/PaymentPart/Output/TcPdfOutput/TcPdfOutput.php, line 358
Sprain\SwissQrBill\PaymentPart\Output\TcPdfOutput\TcPdfOutput::setFurtherInformationElement() /httpdocs/vendor/sprain/swiss-qr-bill/src/PaymentPart/Output/TcPdfOutput/TcPdfOutput.php, line 286
Sprain\SwissQrBill\PaymentPart\Output\TcPdfOutput\TcPdfOutput::setContentElement() /httpdocs/vendor/sprain/swiss-qr-bill/src/PaymentPart/Output/TcPdfOutput/TcPdfOutput.php, line 233
Sprain\SwissQrBill\PaymentPart\Output\TcPdfOutput\TcPdfOutput::addFurtherInformationContent() /httpdocs/vendor/sprain/swiss-qr-bill/src/PaymentPart/Output/TcPdfOutput/TcPdfOutput.php, line 213
Sprain\SwissQrBill\PaymentPart\Output\TcPdfOutput\TcPdfOutput::getPaymentPart() /httpdocs/vendor/sprain/swiss-qr-bill/src/PaymentPart/Output/TcPdfOutput/TcPdfOutput.php, line 89

And here is the code:

$qr = QrBill::create();
$qr->setCreditor(CombinedAddress::create(...));
$qr->setCreditorInformation(CreditorInformation::create(...));
$qr->setUltimateDebtor(StructuredAddress::createWithoutStreet(...));
$qr->setPaymentAmountInformation(PaymentAmountInformation::create('CHF', $total));
$qr->setPaymentReference(PaymentReference::create(PaymentReference::TYPE_QR, $qr_nummer));

$output = new TcPdfOutput($qr, 'de', $pdf);
$output->getPaymentPart();

[kohlerdominik]

Hi @merlincom @supercosh

I suggested a change in #260, but I'm not sure yet if this will be 100% compatible, we need to wait for sprain.

In the meanwwhile, I would appreciate if you could test my fix in your environment? To do that, you need to redirect composer to my fork, and then require the branch with the fix:

In composer.json add this: (at the top as first item, but inside the root-{}, is fine)

    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/kohlerdominik/php-swiss-qr-bill"
        }
    ],

like this

Then update the package

composer require sprain/swiss-qr-bill:dev-pdf-unsupported-characters