Skip to content
This repository has been archived by the owner on Nov 29, 2019. It is now read-only.

"No Shipping" label is vague, does not make it clear that this overwrites the customer's details with the response from Paypal #89

Open
joemsak opened this issue Oct 19, 2012 · 0 comments

Comments

@joemsak
Copy link

joemsak commented Oct 19, 2012

Hi, I am reposting this from spree/spree!

The paypal express gateway takes the details from your paypal account and overwrites the shipping details from that account.

If you want to ship to someone else but use your paypal account to pay, your account's name shouldn't go on their shipping label.

Also, we added a "gift" option that people will likely use to ship directly to the recipient, so their name definitely belongs there.

https://github.com/spree/spree_paypal_express/blob/master/app/controllers/spree/checkout_controller_decorator.rb#L73-74

Here it is in action:

https://gist.github.com/3912735

If the only thing this boolean changes is this behavior, I suggest a label change. If that's all it takes, I'm more than happy to do a pull request and save you guys the trouble

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant