Fix resource leak

spring-petclinic · Dec 31, 2023 · aeca8ae · aeca8ae
1 parent 0e6e000
commit aeca8ae
Showing 1 changed file with 16 additions and 3 deletions.
diff --git a/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java b/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java
@@ -8,6 +8,8 @@
 import jakarta.validation.ConstraintViolation;
 import jakarta.validation.Validator;
 
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.springframework.context.i18n.LocaleContextHolder;
 import org.springframework.validation.beanvalidation.LocalValidatorFactoryBean;
@@ -19,10 +21,17 @@
  */
 class ValidatorTests {
 
-    private Validator createValidator() {
-        LocalValidatorFactoryBean localValidatorFactoryBean = new LocalValidatorFactoryBean();
+    private LocalValidatorFactoryBean localValidatorFactoryBean;
+
+    @BeforeEach
+    void setUp() {
+        localValidatorFactoryBean = new LocalValidatorFactoryBean();
         localValidatorFactoryBean.afterPropertiesSet();
-        return localValidatorFactoryBean.getValidator();
+    }
+
+    @AfterEach
+    void tearDown() {
+        localValidatorFactoryBean.close();
     }
 
     @Test
@@ -42,4 +51,8 @@ void shouldNotValidateWhenFirstNameEmpty() {
         assertThat(violation.getMessage()).isEqualTo("must not be empty");
     }
 
+    private Validator createValidator() {
+        return localValidatorFactoryBean.getValidator();
+    }
+
 }