Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust formats for some files #7

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

sonwan2020
Copy link
Contributor

@sonwan2020 sonwan2020 commented Nov 6, 2024

no functional change

  1. add copyright info to some java files
  2. change the file mode bits for some java files
  3. format pom.xml

@sonwan2020
Copy link
Contributor Author

@arey I forked this repo for future demo purpose
I found there were some format issues and I created this PR
Would you please help review?

Copy link
Member

@arey arey Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is marked as "Empty file" by GitHub.
This is also the case vor Visit, CacheConfiguration and PetControllerTests.
What did you call the "file mode bits" ?

Copy link
Contributor Author

@sonwan2020 sonwan2020 Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is the file mode bits
100755 → 100644, remove the execute bit for java files
when I clone this repo in my windows environment, the tools will update the mode bits for these files

@arey arey added the enhancement New feature or request label Nov 6, 2024
@arey arey merged commit a1a7489 into spring-petclinic:main Nov 6, 2024
1 check passed
@arey
Copy link
Member

arey commented Nov 6, 2024

Thanks a lot @sonwan2020 for your first contribution. Feel free to proposer other enhancement :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants