Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in config-map.yaml - vists instead of visits #21

Open
saxenakshitiz opened this issue Jul 29, 2021 · 3 comments
Open

Fix typo in config-map.yaml - vists instead of visits #21

saxenakshitiz opened this issue Jul 29, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@saxenakshitiz
Copy link

saxenakshitiz commented Jul 29, 2021

diff --git a/k8s/init-services/02-config-map.yaml b/k8s/init-services/02-config-map.yaml
index 32de900..6a8de77 100644
--- a/k8s/init-services/02-config-map.yaml
+++ b/k8s/init-services/02-config-map.yaml
@@ -53,7 +53,7 @@ data:
             enabled: true

     customers-service-id: http://customers-service.spring-petclinic.svc.cluster.local:8080
-    visits-service-id: http://vists-service.spring-petclinic.svc.cluster.local:8080
+    visits-service-id: http://visits-service.spring-petclinic.svc.cluster.local:8080

     spring:
       datasource:
@saxenakshitiz saxenakshitiz changed the title Fix typo in config-map.yaml Fix typo in config-map.yaml - vists instead of visits Jul 29, 2021
@arey arey added the bug Something isn't working label Sep 12, 2021
@arey
Copy link
Member

arey commented Sep 12, 2021

I see the typo in the current 02-config-map.yaml file. @odedia do you know why it's working with it?

@odedia
Copy link
Contributor

odedia commented Sep 19, 2021

I expected that https://github.com/spring-petclinic/spring-petclinic-cloud/blob/master/k8s/init-services/08-visits-service-service.yaml would have the typo as well for it to work but it doesn't seem to be the case. I think we should merge it.

@arey
Copy link
Member

arey commented Sep 19, 2021

Hi @saxenakshitiz, coud you please submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants