Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify modifying repository methods are annotated with @Transactional #3194

Closed
wants to merge 1 commit into from
Closed

Verify modifying repository methods are annotated with @Transactional #3194

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Oct 13, 2023

Fix GH-3188

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 13, 2023
@quaff quaff mentioned this pull request Oct 13, 2023
Closed
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 23, 2023
@quaff
Copy link
Contributor Author

quaff commented Nov 22, 2023

Please note this PR include bugfix not just improvement, it should be resolved ASAP.

@quaff
Copy link
Contributor Author

quaff commented Mar 27, 2024

It seems that the assignee not working for this project anymore, could you reassign another one? @mp911de

@quaff quaff mentioned this pull request Jun 7, 2024
Closed
@mp911de mp911de assigned mp911de and unassigned gregturn Jun 13, 2024
@mp911de mp911de added type: task A general task and removed type: bug A general bug labels Jun 13, 2024
@mp911de mp911de force-pushed the main branch 2 times, most recently from 52ee55f to 61e6d36 Compare October 9, 2024 07:35
@mp911de mp911de removed the type: task A general task label Feb 10, 2025
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 10, 2025
mp911de pushed a commit that referenced this pull request Feb 10, 2025
@quaff @mp911de
Verify modifying methods are annotated with @Transactional
1d99afa 
Closes #3188
Original pull request: #3194
mp911de added a commit that referenced this pull request Feb 10, 2025
@mp911de
Polishing.
7c498d0 
Refine transaction annotation lookup. Structure argument stream.

See #3188
Original pull request: #3194
@mp911de mp911de changed the title Enforce modifying methods are annotated with @Transactional Verify modifying repository methods are annotated with @Transactional Feb 10, 2025
@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 10, 2025
@mp911de mp911de added this to the 3.5 M1 (2025.0.0) milestone Feb 10, 2025
@mp911de
Copy link
Member

mp911de commented Feb 10, 2025

Thank you for your contribution. That's merged and polished.

@mp911de mp911de closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de mp911de left review comments

Assignees

@mp911de mp911de

Labels
type: task A general task
Projects
None yet
Milestone
3.5 M1 (2025.0.0)
4 participants
@quaff @mp911de @gregturn @spring-projects-issues