Skip to content

Add getter for entityManager for more customizable child class #3861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

PelajarPalingArif
Copy link

some simple stuff, dont need any tests

@PelajarPalingArif
Copy link
Author

PelajarPalingArif commented Apr 28, 2025

need to be merged asap and push the jar on maven

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 28, 2025
@schauder
Copy link
Contributor

You can easily grabe the EntityManager from the constructor.
There is no need for additional API surface.

Also, the tone of your communication is not appreciated.

@schauder schauder closed this Apr 29, 2025
@schauder schauder self-assigned this Apr 29, 2025
@schauder schauder added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 29, 2025
@PelajarPalingArif
Copy link
Author

apologies for the tone, I was immature,

are you suggestiong the solution to be like this :

public class ExampleRepository<T, ID> extends SimpleJPARepository<T, ID> {
private EntityManager em;

public ExampleRepository(...., EntityManager em1){
super(...., em1);
this.em = em1;
}
}

this looks unclean

@schauder
Copy link
Contributor

This exactly as it is intended.

@PelajarPalingArif
Copy link
Author

Alright thanks for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants