Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict on Garnet(Replacement of Redis, Implemented by MS, to resolve licensing issue of recent Redis) #3052

Closed
yuseok-kim-edushare opened this issue Nov 21, 2024 · 2 comments
Labels
for: external-project For an external project and not something we can fix

Comments

@yuseok-kim-edushare
Copy link

yuseok-kim-edushare commented Nov 21, 2024

Describe the bug

When I use Garnet to replace Redis
My app written in Java with Spring Boot 3.3 and Spring Data Redis

I tried to test on container side and
Redis CLI works well in PING command
also Application's Execution of Ping works well

but Spring Application Try to connect Garnet, Fail to connect

and I checked logs, and finally found, when using Hello, fault on

Steps to reproduce the bug

  1. create app with some Spring boot app with using Spring Data Redis, will trying to connect garnet
  2. look fail message from spring boot's failure to application run

Expected behavior

working well

Screenshots

Applicaiont Failure message
image

Garnet's Message When Try to RESP v3 Client (Use Hello)
Image

Garnet's Message When Try to RESP v2 Client (Just only Use PING)
Image

Release version

Spring Boot & Data 3.3.5 // Garnet v1.0.39

OS version

Problem first find in
Ubuntu 24.04 LTS Host
running on docker compose (garnet latest, eclipse-temurin:21-jre

test also perfomed on
Windows 10 22H2 latest
.NET 8 latest
Eclipse-Temurin 21 JDK latest


Additional context

I asked first to Microsoft/Garnet but, then I found Garnet's log is clear
microsoft/garnet#811
(Also you can Spring Log in here) https://github.com/Prompt-oven/auth-service/issues/16

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 21, 2024
@mp911de mp911de added for: external-project For an external project and not something we can fix and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 21, 2024
@mp911de
Copy link
Member

mp911de commented Nov 21, 2024

This is actually an issue of the Garnet server that is sending the connection Id as String and not as number. Unfortunately, the Lettuce client doesn't propagate the failure and so you see only a timeout. I filed a PR at redis/lettuce#3058 to propagate the failure. On the Garnet side, it would be great if the HELLO response would stick to how Redis replies.

@mp911de mp911de closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2024
@yuseok-kim-edushare
Copy link
Author

@mp911de Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: external-project For an external project and not something we can fix
Projects
None yet
Development

No branches or pull requests

3 participants