Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SortTranslator ignores snake-cased properties [DATAREST-1276] #1638

Open
spring-projects-issues opened this issue Aug 13, 2018 · 5 comments
Open
Assignees
Labels

Comments

@spring-projects-issues
Copy link

Édouard Hue opened DATAREST-1276 and commented

Given a @Document annotated class with the following attribute, and an according @RepositoryRestResource:

@Field
@JsonProperty("cooking_duration")
private Duration cookingDuration;

When issuing a GET request with ?sort=cooking_duration, the org.springframework.data.rest.webmvc.json.JacksonMappingAwareSortTranslator won't translate cooking_duration to cookingDuration and no sorting is performed.

When changing @JsonProperty("cooking_duration") to @JsonProperty("cooking-duration"), and doing a ?sort=cooking-duration request, JacksonMappingAwareSortTranslator properly resolves the property name.

It looks like org.springframework.data.rest.webmvc.json.JacksonMappingAwareSortTranslator.SortTranslator#SPLITTER is used to split the property name with _ and .. I can see the case for splitting on . for nested properties paths, but why would you split on underscores?


No further details from DATAREST-1276

@kevvvvyp
Copy link

Any update on this one?
Issue is still there in sdr-3.4.6
https://stackoverflow.com/questions/66829865/spring-data-rest-cannot-sort-by-localdatetime-field

It seems it has been around for a while?
https://stackoverflow.com/questions/40746303/spring-data-rest-sorting-fields-with-underscores/40862101#40862101

@tgeens
Copy link
Contributor

tgeens commented Jul 25, 2023

Bumped into this bug today in SDR-3.7.13

@balta3
Copy link

balta3 commented Jan 9, 2024

Any idea when this will be fixed?

@italoborges
Copy link

Same happening to me, any idea when this will be fixed?

@wmrodrigues
Copy link

Does anyone have any updates on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants