Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples for JavaScript ScriptEngine support #27919

Open
1 of 5 tasks
sbrannen opened this issue Jan 11, 2022 · 0 comments
Open
1 of 5 tasks

Update examples for JavaScript ScriptEngine support #27919

sbrannen opened this issue Jan 11, 2022 · 0 comments
Labels
in: core Issues in core modules (aop, beans, core, context, expression) in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Milestone
General Backlog

Comments

@sbrannen
Copy link
Member

sbrannen commented Jan 11, 2022 •
edited
Loading

Overview

Several existing tests as well as examples in the reference manual refer to Nashorn as the supported ScriptEngine for JavaScript; however, Nashorn is no longer supported since Java 15.

In the interim, GraalVM has superseded Nashorn for JavaScript ScriptEngine support.

Deliverables

  • Update Web MVC and WebFlux examples so that they mention GraalVM JS support instead of Nashorn.
  • Create an example project (location yet to be determined) which verifies that GraalVM can be used as the JavaScript ScriptEngine for use with:
    • StandardScriptFactory
    • ScriptTemplateView
  • Delete all Nashorn-specific tests which are currently disabled anyway (via @DisabledForJreRange(min = JAVA_15))
@sbrannen sbrannen added type: documentation A documentation task in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2022
@sbrannen sbrannen added this to the 6.0.0-M3 milestone Jan 11, 2022
@sbrannen sbrannen self-assigned this Mar 15, 2022
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Mar 15, 2022
@sbrannen
Remove obsolete Nashorn-based scripting tests
4db2f8e 
Since the Nashorn JavaScript engine was removed in Java 15, these tests
will never be run on a Java 17+ JDK which is required as of Spring
Framework 6.0.

See spring-projectsgh-27919
@sbrannen sbrannen modified the milestones: 6.0.0-M3, 6.0.0-M4 Mar 15, 2022
@sbrannen sbrannen changed the title Update examples and tests for JavaScript ScriptEngine support Update examples for JavaScript ScriptEngine support Mar 15, 2022
@sbrannen sbrannen modified the milestones: 6.0.0-M4, 6.0.0-M5 May 10, 2022
@sbrannen sbrannen modified the milestones: 6.0.0-M5, 6.0.0-M6 Jun 7, 2022
@sbrannen sbrannen removed their assignment Aug 3, 2022
@sbrannen sbrannen modified the milestones: 6.0.0-M6, 6.0.0-RC1 Aug 29, 2022
@sbrannen sbrannen modified the milestones: 6.0.0-RC1, 6.0.x Oct 10, 2022
@sbrannen sbrannen modified the milestones: 6.0.x, 6.1.x Mar 7, 2023
@snicoll snicoll removed the type: task A general task label Oct 24, 2023
@jhoeller jhoeller modified the milestones: 6.1.x, General Backlog Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core Issues in core modules (aop, beans, core, context, expression) in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Projects
None yet
Milestone
General Backlog
Development

No branches or pull requests
3 participants
@sbrannen @snicoll @jhoeller