Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceUrlEncodingFilter cache misses are expensive #34014

Open
dsyer opened this issue Dec 3, 2024 · 0 comments
Open

ResourceUrlEncodingFilter cache misses are expensive #34014

dsyer opened this issue Dec 3, 2024 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: waiting-for-triage An issue we've not yet triaged or decided on

Comments

@dsyer
Copy link
Member

dsyer commented Dec 3, 2024

A PetClinic user noticed this (spring-projects/spring-petclinic#1732). For me it's a 2x throughput degradation on the home page of PetClinic, for the user that reported the issue it was 4x. The problem seems to be that ResourceUrlEncodingFilter has a CachingResourceResolver in it that works great for actual classpath resources. Conversely, links that are not static resources are cache misses, and they have to be checked every time in case they are, after all, on the classpath (e.g. links to other pages in the app).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 3, 2024
@bclozel bclozel added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Dec 3, 2024
@bclozel bclozel self-assigned this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: waiting-for-triage An issue we've not yet triaged or decided on
Projects
None yet
Development

No branches or pull requests

3 participants